fix: remove blue border in firefox #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritro2002
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
|
Review changes with SemanticDiff. |
PritishBudhiraja
added
the
Ready for Review
PritishBudhiraja
temporarily deployed
to
Testing
GitHub Actions
Inactive
github-actions
bot
added
Closed
seekshiva
pushed a commit
that referenced
this pull request
Oct 29, 2024
## [0.96.3](v0.96.2...v0.96.3) (2024-10-29) ### Bug Fixes * remove blue border in firefox ([#746](#746)) ([40ef7a5](40ef7a5))
aritro2002
added a commit
that referenced
this pull request
Oct 30, 2024
10 tasks
PritishBudhiraja
pushed a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When clicking on the button, or active iframe in Firefox, a blue border appears. This is caused by default browser behavior.
To resolve this, I have made every tags outline transparent when they are in focus and active state. The CSS change is applied specifically for Firefox to avoid affecting other browsers.
Reference:
Before:
After:
How did you test it?
Tested via rendering the SDK in firefox ,safari and chrome
Checklist
npm run re:build